Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): dataplane selector control API #4291

Conversation

timdah
Copy link
Contributor

@timdah timdah commented Jun 20, 2024

What this PR changes/adds

Fixes a dataplane selector control API endpoint.

Why it does that

Add a missing transformer.

Further notes

/

Linked Issue(s)

Closes #4245

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a good occasion for adding an e2e test on this endpoint, please fix the pr title and you have to sign the ECA

@timdah timdah changed the title fix(data-plane-selector-control-api): getAllDataPlaneInstances endpoint fix(api): dataplane selector control API Jun 20, 2024
@ronjaquensel ronjaquensel added bug Something isn't working api Feature related to the (REST) api labels Jun 20, 2024
@timdah timdah force-pushed the bugfix/4245-MissingTransformer branch from 34ee24b to c4e45be Compare June 20, 2024 14:08
@timdah timdah force-pushed the bugfix/4245-MissingTransformer branch from c4e45be to a972b2e Compare June 20, 2024 14:18
@timdah
Copy link
Contributor Author

timdah commented Jun 20, 2024

this could be a good occasion for adding an e2e test on this endpoint, please fix the pr title and you have to sign the ECA

added an e2e test and fixed the title

@timdah timdah requested a review from ndr-brt June 20, 2024 14:42
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paullatzelsperger paullatzelsperger merged commit 84b811e into eclipse-edc:main Jun 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing transformer in data-plane-selector-control-api
4 participants